Khaki, white, and grey all work very well as colors for shorts in such a combination, but jean shorts are too casual and black shorts are a bit harsh. As far as shirt colors, you can choose pretty much any color and a pattern as long as it is classic and not too busy or too bright. I would finish it off with a pair of brown leather flip flops. This type of look also works well with polo shirts and boat shoes.